sql: fix error message for currval, nextval and setval for sequences #70590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RichardJCai
force-pushed
the
fix_sequence_builtin_error_msg_092221
branch
2 times, most recently
from
a73197e to
bc13103
Compare
RichardJCai
requested review from
a team and
adityamaru
and removed request for
a team
otan
approved these changes
Sep 22, 2021
Release note (sql change): Small fix to error messaging for
builtin functions for sequences.
Example: SELECT nextval('@#%@!324234') correctly returns
relation "@#%@!324234" does not exist (if the relation doesn't exist)
instead of a syntax error.
SELECT currval('') returns currval\(\): invalid table name: instead of
pq: currval(): syntax error at or near "to"
DETAIL: source SQL:
ALTER TABLE RENAME TO x
^
HINT: try \h ALTER TABLE
RichardJCai
force-pushed
the
fix_sequence_builtin_error_msg_092221
branch
from
bc13103 to
328ef65
Compare
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (sql change): Small fix to error messaging for
builtin functions for sequences.
Example: SELECT nextval('@#%@!324234') correctly returns
relation "@#%@!324234" does not exist (if the relation doesn't exist)
instead of a syntax error.
SELECT currval('') returns currval(): invalid table name: instead of
pq: currval(): syntax error at or near "to"
DETAIL: source SQL:
ALTER TABLE RENAME TO x
^
HINT: try \h ALTER TABLE
Fixes #34527